organised functions

This commit is contained in:
liyunze 2026-07-07 19:06:17 +10:00
parent c818ddd8e5
commit 9f88bf05b8

View file

@ -4,15 +4,219 @@ use crate::{
Data, Error,
commands::verification::{StudentRow, VerificationModal},
};
use ::serenity::all::{
Context, CreateEmbed, CreateEmbedFooter, CreateInteractionResponse,
CreateInteractionResponseMessage, GuildId, RoleId,
use ::serenity::{
all::{
ComponentInteraction, Context, CreateEmbed, CreateEmbedFooter, CreateInteractionResponse,
CreateInteractionResponseMessage, GuildId, ModalInteraction, RoleId,
collector::ModalInteractionCollector,
},
model::guild::Member,
};
use dotenv::dotenv;
use poise::Modal as _;
use poise::serenity_prelude as serenity;
/// Read the verified role id from the environment.
fn verified_role_id() -> RoleId {
dotenv().ok();
let role_id_string = std::env::var("VERIFIED_ROLE_ID").expect("missing VERIFIED_ROLE_ID");
let role_id_u64: u64 = role_id_string
.parse()
.expect("Unable to parse VERIFIED_ROLE_ID into number");
RoleId::new(role_id_u64)
}
/// Wrap an embed into an ephemeral interaction response.
fn ephemeral_embed(embed: CreateEmbed) -> CreateInteractionResponse {
CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(embed)
.ephemeral(true),
)
}
/// Show the verification modal and wait for (and parse) the submission.
///
/// Returns `None` when the user let the modal time out or the submission
/// could not be parsed (an error response is sent in the latter case).
async fn collect_verification_modal(
ctx: &Context,
component_interaction: &ComponentInteraction,
) -> Result<Option<(ModalInteraction, VerificationModal)>, Error> {
let modal_custom_id = component_interaction.id.to_string();
let modal = VerificationModal::create(None, modal_custom_id.clone());
component_interaction.create_response(ctx, modal).await?;
let modal_submit = ModalInteractionCollector::new(&ctx.shard)
.filter(move |d| d.data.custom_id == modal_custom_id)
.timeout(Duration::from_secs(120))
.await;
let Some(modal_submit) = modal_submit else {
return Ok(None);
};
match VerificationModal::parse(modal_submit.data.clone()) {
Ok(data) => Ok(Some((modal_submit, data))),
Err(_) => {
modal_submit
.create_response(
ctx,
ephemeral_embed(
CreateEmbed::new()
.title("Error")
.description("Failed to parse modal data. Please try again."),
),
)
.await?;
Ok(None)
}
}
}
/// Assign the verified role and send the success response.
async fn grant_verified_role(
ctx: &Context,
modal_submit: &ModalInteraction,
discord_member: &Member,
verified_role_id: RoleId,
via_cache: bool,
) -> Result<(), Error> {
discord_member.add_role(ctx, verified_role_id).await?;
let mut embed = CreateEmbed::new().title("Verified ✅").description(format!(
"You have been assigned the <@&{}> role!",
verified_role_id
));
if via_cache {
embed = embed.footer(CreateEmbedFooter::new("⚡ via cache"));
}
modal_submit
.create_response(ctx, ephemeral_embed(embed))
.await?;
Ok(())
}
/// Whether the cached name for `student_id` matches the submitted `name`.
fn cached_name_matches(data: &Data, student_id: &str, name: &str) -> bool {
let cache = data
.state
.student_cache
.lock()
.expect("Failed to get cache");
match cache.get(student_id) {
Some(cached_name) => cached_name == &name.to_lowercase(),
None => false,
}
}
/// Store the resolved student name in the cache (lower-cased for comparison).
fn cache_student(data: &Data, student_id: &str, full_name: &str) {
let mut cache = data.state.student_cache.lock().unwrap();
cache.insert(student_id.to_string(), full_name.to_lowercase());
}
/// Look up a student by id in the database.
async fn fetch_student(data: &Data, student_id: &str) -> Result<Option<StudentRow>, Error> {
let student_data: Vec<StudentRow> = data
.state
.supabase
.database()
.from("active_members")
.select("full_name, student_id")
.eq("student_id", student_id)
.execute()
.await?;
Ok(student_data.into_iter().next())
}
/// Handle a click on the "verify" button: collect the modal, then verify the
/// submitted student id/name against the cache and database.
async fn handle_verify(
ctx: &Context,
component_interaction: &ComponentInteraction,
data: &Data,
) -> Result<(), Error> {
let Some(guild_id) = component_interaction.guild_id else {
component_interaction
.create_response(
ctx,
ephemeral_embed(
CreateEmbed::new()
.title("Unable to perform action")
.description("Action can only be performed in the DSEC server"),
),
)
.await?;
return Ok(());
};
let verified_role_id = verified_role_id();
let user_id = component_interaction.user.id;
let discord_member = GuildId::member(guild_id, ctx, user_id).await?;
if discord_member.roles.contains(&verified_role_id) {
component_interaction
.create_response(
ctx,
ephemeral_embed(CreateEmbed::new().title("Already Verified ✅").description(
format!("You already have the <@&{}> role!", verified_role_id),
)),
)
.await?;
return Ok(());
}
let Some((modal_submit, modal_data)) =
collect_verification_modal(ctx, component_interaction).await?
else {
return Ok(());
};
let input_student_id = modal_data.student_id.to_lowercase();
let student_id = input_student_id
.strip_prefix("s")
.unwrap_or(&input_student_id);
if cached_name_matches(data, student_id, &modal_data.name) {
grant_verified_role(ctx, &modal_submit, &discord_member, verified_role_id, true).await?;
return Ok(());
}
let Some(student) = fetch_student(data, student_id).await? else {
modal_submit
.create_response(
ctx,
ephemeral_embed(
CreateEmbed::new().title("Student ID not found!").description(
"Your student ID is not found.\nIt takes up to **a week** for your membership to be updated in the database since sign up.\nTry again later.",
),
),
)
.await?;
return Ok(());
};
cache_student(data, student_id, &student.full_name);
if student.full_name.to_lowercase() == modal_data.name.to_lowercase() {
grant_verified_role(ctx, &modal_submit, &discord_member, verified_role_id, false).await?;
} else {
modal_submit
.create_response(
ctx,
ephemeral_embed(CreateEmbed::new().title("Name mismatch ❌").description(
"Your student ID is present, however the name does not match. Try again.",
)),
)
.await?;
}
Ok(())
}
pub async fn on_interaction_create(
ctx: &Context,
interaction: &serenity::Interaction,
@ -23,161 +227,7 @@ pub async fn on_interaction_create(
};
if component_interaction.data.custom_id == "verify" {
dotenv().ok();
let guild_id = match component_interaction.guild_id {
Some(id) => id,
None => {
component_interaction.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(CreateEmbed::new()
.title("Unable to perform action")
.description("Action can only be performed in the DSEC server"))
.ephemeral(true),
)).await?;
return Ok(());
}
};
let role_id_string = std::env::var("VERIFIED_ROLE_ID").expect("missing VERIFIED_ROLE_ID");
let role_id_u64: u64 = role_id_string
.parse()
.expect("Unable to parse VERIFIED_ROLE_ID into number");
let user_id = component_interaction.user.id;
let verified_role_id = RoleId::new(role_id_u64);
let discord_member = GuildId::member(guild_id, ctx, user_id).await?;
if discord_member.roles.contains(&verified_role_id) {
component_interaction.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(CreateEmbed::new()
.title("Already Verified ✅")
.description(format!("You already have the <@&{}> role!", verified_role_id)))
.ephemeral(true),
)).await?;
return Ok(());
}
let modal_custom_id = component_interaction.id.to_string();
let modal = VerificationModal::create(None, modal_custom_id.clone());
component_interaction.create_response(ctx, modal).await?;
let modal_submit = ModalInteractionCollector::new(&ctx.shard)
.filter(move |d| d.data.custom_id == modal_custom_id)
.timeout(Duration::from_secs(120))
.await;
let modal_submit = match modal_submit {
Some(x) => x,
None => return Ok(()),
};
let modal_data = match VerificationModal::parse(modal_submit.data.clone()) {
Ok(data) => data,
Err(_) => {
modal_submit.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(CreateEmbed::new()
.title("Error")
.description("Failed to parse modal data. Please try again."))
.ephemeral(true),
)).await?;
return Ok(());
}
};
let input_student_id: &str = &modal_data.student_id.to_lowercase();
let student_id = input_student_id
.strip_prefix("s")
.unwrap_or(input_student_id);
let state = &data.state;
let student_in_cache: bool = {
let cache = state.student_cache.lock().expect("Failed to get cache");
match cache.get(student_id) {
Some(cached_name) => cached_name == &modal_data.name.to_lowercase(),
None => false,
}
};
if student_in_cache {
discord_member.add_role(ctx, verified_role_id).await?;
let embed = CreateEmbed::new()
.title("Verified ✅")
.description(format!(
"You have been assigned the <@&{}> role!",
verified_role_id
))
.footer(CreateEmbedFooter::new("⚡ via cache"));
modal_submit.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(embed)
.ephemeral(true),
)).await?;
return Ok(());
}
let student_data: Vec<StudentRow> = state
.supabase
.database()
.from("active_members")
.select("full_name, student_id")
.eq("student_id", &student_id)
.execute()
.await?;
let result = student_data.iter().next();
if result.is_none() {
modal_submit.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(CreateEmbed::new()
.title("Student ID not found!")
.description("Your student ID is not found.\nIt takes up to **a week** for your membership to be updated in the database since sign up.\nTry again later."))
.ephemeral(true),
)).await?;
return Ok(());
}
let result_name = &result.unwrap().full_name;
{
let mut cache = state.student_cache.lock().unwrap();
cache.insert(
student_id.to_string(),
result_name.to_string().to_lowercase(),
);
}
if &result_name.to_lowercase() == &modal_data.name.to_lowercase() {
discord_member.add_role(ctx, verified_role_id).await?;
let embed = CreateEmbed::new()
.title("Verified ✅")
.description(format!(
"You have been assigned the <@&{}> role!",
verified_role_id
));
modal_submit.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(embed)
.ephemeral(true),
)).await?;
} else {
modal_submit.create_response(ctx, CreateInteractionResponse::Message(
CreateInteractionResponseMessage::new()
.add_embed(CreateEmbed::new()
.title("Name mismatch ❌")
.description("Your student ID is present, however the name does not match. Try again."))
.ephemeral(true),
)).await?;
}
handle_verify(ctx, component_interaction, data).await?;
}
Ok(())